-
-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump worklfow deps #2233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I guess it'll work. Please note however that you are changing major version of dependencies -> please take a look at respective changelogs & check out what are the breaking changes of each dependency you changed. After you've done that we can merge.
@kkafar I've updated the PR's description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
## Description This PR bumps dependencies used in workflows to the latest versions In most cases bump to v3 means that the Node runtime is updated from 12 to 16 and bump to v4 means it's updated to 20. Additional changes are not affecting our workflows and are as follows: - actions/setup-node@v3 changed flag name from `version` to `node-version` - actions/cache@v4 added a new flag `save-always` - actions/upload-artifact@v4 changed how operating on multiple files works: [migration docs](https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md) ## Changes <!-- Please describe things you've changed here, make a **high level** overview, if change is simple you can omit this section. For example: - Updated `about.md` docs --> <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Test code and steps to reproduce <!-- Please include code that can be used to test this change and short description how this example should work. This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example) --> ## Checklist - [x] Ensured that CI passes
## Description This PR bumps dependencies used in workflows to the latest versions In most cases bump to v3 means that the Node runtime is updated from 12 to 16 and bump to v4 means it's updated to 20. Additional changes are not affecting our workflows and are as follows: - actions/setup-node@v3 changed flag name from `version` to `node-version` - actions/cache@v4 added a new flag `save-always` - actions/upload-artifact@v4 changed how operating on multiple files works: [migration docs](https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md) ## Changes <!-- Please describe things you've changed here, make a **high level** overview, if change is simple you can omit this section. For example: - Updated `about.md` docs --> <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Test code and steps to reproduce <!-- Please include code that can be used to test this change and short description how this example should work. This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example) --> ## Checklist - [x] Ensured that CI passes
Description
This PR bumps dependencies used in workflows to the latest versions
In most cases bump to v3 means that the Node runtime is updated from 12 to 16 and bump to v4 means it's updated to 20.
Additional changes are not affecting our workflows and are as follows:
version
tonode-version
save-always
Changes
Test code and steps to reproduce
Checklist